Review Request: Add "Open With" actions to KFileDialog context menu [via KDirOperator]

[Harsh J]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2757/
-----------------------------------------------------------

(Updated 2010-01-28 20:32:37.547970)


Review request for kdelibs, Shaun Reich and David Faure.


Changes
-------

Used kApplication()->applicationName() to not show self-application in the trader query results.

This looks a bit ugly (don't know how safe too..) but its necessary since (ex.) choosing Kate within Kate makes it hang.


Summary
-------

This patch proposes to use KFileItemActions class to add "Open With" actions to the context menu of selected file(s) in KDirOperator (which is used by KFileDialog).

Some points on the implementation:
 * Added the action under the KDirOperator::FileActions flag
 * Made openWithActions (a KFileItemActions object) a member of the private KDO class
 * Initialized the same object in setupActions() method

I suppose I must add something to KDirOperator::updatedSelectionDependentActions() but I don't think its necessary as the selected items are retrieved while setting up this menu itself. Would be better to add a reloader there just in case though. Opinions please?

Also, is there a way to make the KDirOperator realize the name of the application that's using it? I could use that to block itself out of the suggestions via the traderConstraints. Doesn't look possible afaik.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kfile/kdiroperator.cpp 1081124 

Diff: http://reviewboard.kde.org/r/2757/diff


Testing
-------

* Selected no items and right clicked - no submenu/separator shows.
* Selected one item - Open With submenu and sometimes (in cases where only one can open)
    preferred open with option shows.
* Selected multiple items - Open With submenu and sometimes (in cases where only one can open)
    preferred open with option shows.
* Repeat above two with directories successfully shows the same.


Screenshots
-----------

Open With actions in KFileDialog
  http://reviewboard.kde.org/r/2757/s/305/


Thanks,

Harsh