Review Request: kde4-config --version doesn't work as advertised

[Aaron Seigo]

> On 2010-01-28 06:12:31, Aaron Seigo wrote:
> > hm, here, with vanilla trunk and qt, i get:
> > 
> > > kde4-config --version
> > Qt: 4.6.1
> > KDE Development Platform: 4.4.60 (KDE 4.4.60 (KDE 4.5 >= 20100120))
> > kde4-config: 1.0
> > 
> > i wonder what's different so that you don't get that output?
> 
> Rex Dieter wrote:
>     Now, compare the output you got with the code in kde-config.cpp
>     
>         if (args->isSet("version"))
>         {
>             printf("%s\n", KDE_VERSION_STRING);
>             return 0;
>         }
>     
>     See the problem now? :)

ah! *just* the kde version string; ok, i see why you've added a separate switch for it now. (as an aside: the --version showing all the version info is quite nice to find out what qt + kde verion people are using)


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2745/#review3924
-----------------------------------------------------------


On 2010-01-28 00:10:38, Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2745/
> -----------------------------------------------------------
> 
> (Updated 2010-01-28 00:10:38)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Make a new option, tentatively, named --kde-version that does what --version was supposed to do.
> 
> See also,
> https://bugs.kde.org/224540
> 
> Either this, or just remove the useless code.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/kde-config.cpp 1081218 
> 
> Diff: http://reviewboard.kde.org/r/2745/diff
> 
> 
> Testing
> -------
> 
> build with patch, now get:
> 
> $ ./kde4-config --kde-version
> 4.3.95 (KDE 4.3.95 (KDE 4.4 RC2))
> 
> 
> Thanks,
> 
> Rex
> 
>