Review Request: Unquoted/unescaped directory name passed to "cd" command in dolphin embedded terminal

[Oswald Buddenhagen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2703/#review3909
-----------------------------------------------------------


huh, misunderstanding. :}
i meant the tilde can stay as you did it, as obviously the hash mark is handled just as "carelessly".

- Oswald


On 2010-01-27 15:24:06, Nicolas Lécureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2703/
> -----------------------------------------------------------
> 
> (Updated 2010-01-27 15:24:06)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch add !~[] as special letters to be escaped, this fix the use of the embeded terminal
> 
> 
> This addresses bug 220092.
>     https://bugs.kde.org/show_bug.cgi?id=220092
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/util/kshell_unix.cpp 1081034 
> 
> Diff: http://reviewboard.kde.org/r/2703/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
>