Review Request: Pathch for wish : no way to add a file by rightclicking to a folder, bug 93230

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2535/#review3908
-----------------------------------------------------------



/trunk/KDE/kdelibs/kfile/kdiroperator.h
<http://reviewboard.kde.org/r/2535/#comment3280>

    "options file options"? I don't follow.
    
    show -> shown



/trunk/KDE/kdelibs/kfile/kdiroperator.h
<http://reviewboard.kde.org/r/2535/#comment3278>

    missing "@since 4.5"



/trunk/KDE/kdelibs/kfile/kdiroperator.h
<http://reviewboard.kde.org/r/2535/#comment3279>

    @since 4.5



/trunk/KDE/kdelibs/kfile/kdiroperator.cpp
<http://reviewboard.kde.org/r/2535/#comment3281>

    no need to test for isEmpty before calling clear(), just call clear().



/trunk/KDE/kdelibs/kfile/kdiroperator.cpp
<http://reviewboard.kde.org/r/2535/#comment3283>

    No need to store the list both here and inside KNewFileMenu. I see you added an accessor, that's probably why you added the member var, but let's not duplicate the info. I added an accessor in KNewFileMenu now, you can remove d->supportedMimeTypes from here.



/trunk/KDE/kdesdk/kate/plugins/filebrowser/katefilebrowser.cpp
<http://reviewboard.kde.org/r/2535/#comment3282>

    can be removed ;)


- David


On 2010-01-26 06:44:32, Abhishek Patil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2535/
> -----------------------------------------------------------
> 
> (Updated 2010-01-26 06:44:32)
> 
> 
> Review request for Kate and kdelibs.
> 
> 
> Summary
> -------
> 
> Right click in filesystem browser you will find new option called "New File..." which will create a new Empty file at given location.
> 
> 
> This addresses bug 93230.
>     https://bugs.kde.org/show_bug.cgi?id=93230
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/kdiroperator.h 1080317 
>   /trunk/KDE/kdelibs/kfile/kdiroperator.cpp 1080317 
>   /trunk/KDE/kdesdk/kate/plugins/filebrowser/katefilebrowser.cpp 1080317 
> 
> Diff: http://reviewboard.kde.org/r/2535/diff
> 
> 
> Testing
> -------
> 
> Tested on Trunk Revision: 1071973
> 
> 
> Screenshots
> -----------
> 
> Context Menu New
>   http://reviewboard.kde.org/r/2535/s/294/
> 
> 
> Thanks,
> 
> Abhishek
> 
>