Review Request: KIO::TransferJob member function for disabling internal redirection handling...

[adawit at kde.org]

> On 2010-01-25 10:27:31, David Faure wrote:
> > /branches/KDE/4.4/kdelibs/kio/kio/jobclasses.h, line 614
> > <http://reviewboard.kde.org/r/2726/diff/2/?file=17743#file17743line614>
> >
> >     forward -> forwarded

Done. I have one question though... Since simple jobs like KIO::StatJob also perform redirection, is there a need to add this very same functionality to them ? If so should I move these two new functions to KIO::SimpleJob and add the same support to those classes as well ?


- adawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2726/#review3861
-----------------------------------------------------------


On 2010-01-25 04:34:03, adawit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2726/
> -----------------------------------------------------------
> 
> (Updated 2010-01-25 04:34:03)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> Currently there is no way to prevent KIO from automatically handling redirection requests internally. Unfortunately, this causes a lot of issues for the class used to provide KIO integration to QtWebKit, KIO::AccessManager, because QtWebKit handles redirections internally too! In other words, there is no way to stop one of these two modules from doing the redirection. Since all the hacks and workarounds used so far have their own issues that end up causing bugs, for example you cannot currently login into blogger.com using konqueror+kwebkitpart, I have created a patch to address this issue properly.
> 
> The attached patch adds two member functions to KIO::TransfterJob that allows a programmer to explicitly disable internal handling of redirection requests. The default behavior remains exactly as it is now, i.e. redirections are automatically handled internally. 
> 
> 
> Since this change is essentially a bug fix for a brand new module in kdelibs, I would like to apply this patch before to the 4.4 goes out.
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.4/kdelibs/kio/kio/job.cpp 1078331 
>   /branches/KDE/4.4/kdelibs/kio/kio/job_p.h 1078331 
>   /branches/KDE/4.4/kdelibs/kio/kio/jobclasses.h 1078331 
> 
> Diff: http://reviewboard.kde.org/r/2726/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> adawit
> 
>