Review Request: Add Qt::Key_Escape shortcut to KHTMLFindBarWidget within the KHTML kpart

Germain Garand germain at ebooksfrance.org
Mon Jan 25 05:16:18 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2691/#review3858
-----------------------------------------------------------


if you read the comment in KHTMLFindBar::event, you'll see it is implemented this way to avoid conflicting with the window-global shortcuts.

For instance, in konqueror, the default use for esc shortcut is to stop loading the page (as in most, if not all browsers).

It is considered closing the search dialog from another focused widget isn't an important enough functionality (as the overwhelming use case is to close the dialog when it still has focus) to be worth the trouble of a window-level shortcut conflict.

There might be other important uses for escape in different applications using KHTMLPart.

Alternative solution would be to have a different default shortcut for closing the search bar.
This isn't really possible though, as users expect that shortcut to work this way, as it is pretty much standard.

You may verify that all browsers behave the same /wrt to default key_escape behaviour, btw.

- Germain


On 2010-01-22 20:02:43, Sascha Peilicke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2691/
> -----------------------------------------------------------
> 
> (Updated 2010-01-22 20:02:43)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This allows to hide the findbar/searchbar in Konqi via pressing the escape key when the findbar lost focus and thus saves a mouse-click. This also aligns Konqi's behavior to what Okular does.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/khtml/khtmlviewbarwidget.cpp 1078720 
> 
> Diff: http://reviewboard.kde.org/r/2691/diff
> 
> 
> Testing
> -------
> 
> works with konqi from trunk r1078720.
> 
> 
> Thanks,
> 
> Sascha
> 
>





More information about the kde-core-devel mailing list