Review Request: Add Qt::Key_Escape shortcut to KHTMLFindBarWidget within the KHTML kpart

[Vikram Dhillon]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2691/#review3827
-----------------------------------------------------------


Seems fine to me, as you said it does indeed call Key_Escape for the escape key :) but this one is my first review so please be easy on me people.

- Vikram 


On 2010-01-22 20:02:43, Sascha Peilicke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2691/
> -----------------------------------------------------------
> 
> (Updated 2010-01-22 20:02:43)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This allows to hide the findbar/searchbar in Konqi via pressing the escape key when the findbar lost focus and thus saves a mouse-click. This also aligns Konqi's behavior to what Okular does.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/khtml/khtmlviewbarwidget.cpp 1078720 
> 
> Diff: http://reviewboard.kde.org/r/2691/diff
> 
> 
> Testing
> -------
> 
> works with konqi from trunk r1078720.
> 
> 
> Thanks,
> 
> Sascha
> 
>