Review Request: kio-file: sync file copy to /media/

[Davide Bettio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2690/
-----------------------------------------------------------

(Updated 2010-01-22 20:42:25.852120)


Review request for kdelibs, Kevin Ottens and David Faure.


Changes
-------

Added ervin because he knows how solid works.


Summary
-------

This simple patch allows file copy to external devices to be synchronous. This patch assumes that external devices are mounted on a subdirectory of /media/. If /media/ is not used this patch will not work so everything will be as before.
For more dettails see also https://bugs.kde.org/show_bug.cgi?id=195044.


Diffs
-----

  /trunk/KDE/kdelibs/kioslave/file/file_unix.cpp 1077183 

Diff: http://reviewboard.kde.org/r/2690/diff


Testing
-------

This patch is recent, so I'm testing it right now. kio-file is a critical component so I will do more tests.

Checking for file corruption might be a good idea:
dd if=/dev/full of=testFile count=numOfBlocks
md5sum testFile
Copy it, umount, mount and check the md5sum.


Thanks,

Davide