Review Request: kio-file: sync file copy to /media/

[Andras Mantia]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2690/#review3797
-----------------------------------------------------------


Did you profile the copying speed? Are you sure it will not wear out too quickly the USB media? Maybe O_SYNC is better than using full sync mount, but I'd not introduce the change without profiling and testing (a lot) on USB memories.

- Andras


On 2010-01-22 20:31:01, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2690/
> -----------------------------------------------------------
> 
> (Updated 2010-01-22 20:31:01)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> This simple patch allows file copy to external devices to be synchronous. This patch assumes that external devices are mounted on a subdirectory of /media/. If /media/ is not used this patch will not work so everything will be as before.
> For more dettails see also https://bugs.kde.org/show_bug.cgi?id=195044.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kioslave/file/file_unix.cpp 1077183 
> 
> Diff: http://reviewboard.kde.org/r/2690/diff
> 
> 
> Testing
> -------
> 
> This patch is recent, so I'm testing it right now. kio-file is a critical component so I will do more tests.
> 
> Checking for file corruption might be a good idea:
> dd if=/dev/full of=testFile count=numOfBlocks
> md5sum testFile
> Copy it, umount, mount and check the md5sum.
> 
> 
> Thanks,
> 
> Davide
> 
>