Review Request: Honor the possible custom folder icon in the Folder preview (thumbnail kioslave)

[Darío Andrés]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2658/
-----------------------------------------------------------

Review request for kdelibs, Peter Penz, David Nolden, and David Faure.


Summary
-------

Current Folder preview generator (which shows thumbnails of the folder contents images/files) doesn't honor the possible custom folder icon.
Using "KMimeType::iconNameForUrl" we can determine the custom icon inside the ".directory" file (if available) or fallback to the normal folder icon.
As the thumbnail generator method for folders get a KUrl with the "thumbnail:/" schema, "KMimeType::iconNameForUrl" is not going to work. 

As I saw this is likely to work only with local files I added a scheme change (to "file:/") in order to make the function work again. However, I'm not really sure about this.


This addresses bug 201850.
    https://bugs.kde.org/show_bug.cgi?id=201850


Diffs
-----

  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/runtime/kioslave/thumbnail/thumbnail.cpp 1077195 

Diff: http://reviewboard.kde.org/r/2658/diff


Testing
-------

Custom icons are honored in the folder preview. Folders without custom icon still use the normal image.


Thanks,

Darío