Review Request: Add a new KPasswordLineEditidget

Charles Ghislain charlyghislain at
Thu Jan 14 13:56:08 GMT 2010

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.



I started adding a warning label to kpassworddialog, then i noticed that password fields were used at various place outside a kpassworddialog or a knewpassworddialog. Take for instance kmail, konversation,
kdm, ... I was told the idea is that applications should use those dialogs, but the reallity seems different. Implementing the capslock warning in a new kpasswordlineedit allow all those apps to get the benefits.

This is my first contribution, I'm new to C++ and KDE and Qt in general. I tried copying from other sources i found, but there are still issues i can't resolve by myself yet :
- Memory leaks : i don't know were is it - should i delete the childeren widgets in the destructor?
- Formatting : i guess it refers to the widget having differenc height when the label is shown or not. I don't know how to make sure the widget keeps a fixed height even if one of his childeren is hidden. I could just set the text to label to a whitespace and keep is shown, but i guess there is a proper way.
- Warning color : I used hardcoded red, i didn't find how to use themed colors
- Others issues i don't think of right know.



This addresses bug 91970.


  trunk/KDE/kdelibs/kdeui/CMakeLists.txt 1074640 
  trunk/KDE/kdelibs/kdeui/widgets/kpasswordlineedit.h PRE-CREATION 
  trunk/KDE/kdelibs/kdeui/widgets/kpasswordlineedit.cpp PRE-CREATION 
  trunk/KDE/kdelibs/kdewidgets/kde.widgets 1074640 



I tested in designer and replaced the password field of kpassworddialog with it.



More information about the kde-core-devel mailing list