Review Request: kstyle default keyboard navigation features in QTreeView

Hugo Pereira Da Costa hugo.pereira at free.fr
Wed Jan 13 00:12:21 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2565/
-----------------------------------------------------------

(Updated 2010-01-13 00:12:21.732061)


Review request for kdelibs.


Summary
-------

This patch addresses bug report 160024 (https://bugs.kde.org/show_bug.cgi?id=160024) on QTreeView navigation using arrows.
Default behavior (from QCommonStyle) when one presses the left arrow in a non expandable child item, is to do nothing. Requested default behavior, for styles that inherits kstyle, (and already implemented on Qt Windows style as well as Oxygen) is to jump to the parent item. 

Since no alternative default action is associated to this action, we don't see any reason not to enable the navigation behavior above, as a kstyle default, since it turns out to be quite handy. 

Besides, styles deriving from kstyle can always disable it. 


This addresses bug 160024.
    https://bugs.kde.org/show_bug.cgi?id=160024


Diffs
-----

  /trunk/KDE/kdelibs/kdeui/kernel/kstyle.cpp 1073856 

Diff: http://reviewboard.kde.org/r/2565/diff


Testing
-------

Tested in dolphin, systemsettings, using oxygen style.


Thanks,

Hugo





More information about the kde-core-devel mailing list