Review Request: KColorCombo: using roundedRects instead of rects.

Michael Pyne mpyne at kde.org
Mon Jan 11 23:42:04 GMT 2010



> On 2010-01-11 18:39:15, Aaron Seigo wrote:
> > absolutely; die, sharp corners, die!
> 
> Davide Bettio wrote:
>     Should I backport this commit?

By the letter of rule, no. /But/ it would look much nicer and 4.5 will be such a long way away ;-). I'll let someone on Release Team be the judge though.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2544/#review3665
-----------------------------------------------------------


On 2010-01-10 22:04:39, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2544/
> -----------------------------------------------------------
> 
> (Updated 2010-01-10 22:04:39)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> I replaced rects with roundedRects so the widget looks nicer.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/colors/kcolorcombo.cpp 1072736 
> 
> Diff: http://reviewboard.kde.org/r/2544/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Rounded rects
>   http://reviewboard.kde.org/r/2544/s/296/
> 
> 
> Thanks,
> 
> Davide
> 
>





More information about the kde-core-devel mailing list