[RFC] ignore white space changes in commit mails

Ingo Klöcker kloecker at kde.org
Mon Jan 11 22:04:41 GMT 2010


On Monday 11 January 2010, André Wöbbeking wrote:
> On Sunday 10 January 2010, Michael Pyne wrote:
> > On Sunday 10 January 2010 13:59:36 André Wöbbeking wrote:
> > but I would
> > not strip them out entirely, there's a risk that if we mess up the
> > implementation of that feature that someone could slip something
> > malicious into a "whitespace- only" change (no I don't have an
> > example, merely paranoia ;)
> >
> > > pros:
> > > - as the real change becomes more "visible" it's easier to review
> >
> > This is a good reason to make the change, but perhaps we should
> > make the improvement in e.g. Kompare instead of the commit mails?
>
> So you want to start Kompare for every commit mail?

No. KMail should simply use a Kompare part for showing the diffs.


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100111/e9d26482/attachment.sig>


More information about the kde-core-devel mailing list