Review Request: KColorCombo: using roundedRects instead of rects.

Michael Pyne mpyne at kde.org
Mon Jan 11 00:16:19 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2544/#review3645
-----------------------------------------------------------


Looks good to me, you should probably also ask one of the KDE artists though.

- Michael


On 2010-01-10 22:04:39, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2544/
> -----------------------------------------------------------
> 
> (Updated 2010-01-10 22:04:39)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> I replaced rects with roundedRects so the widget looks nicer.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/colors/kcolorcombo.cpp 1072736 
> 
> Diff: http://reviewboard.kde.org/r/2544/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Rounded rects
>   http://reviewboard.kde.org/r/2544/s/296/
> 
> 
> Thanks,
> 
> Davide
> 
>





More information about the kde-core-devel mailing list