Review Request: New KColorCombo palette

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2476/#review3639
-----------------------------------------------------------

Ship it!


With the minor things mentioned fixed the patch looks good. I didn't see any areas where the values of KColorCombo actually get serialized (i.e. it deals with colors directly in the API) so I don't see any other parts that need changed to modify the colors and their order.


/trunk/KDE/kdelibs/kdeui/colors/kcolorcombo.cpp
<http://reviewboard.kde.org/r/2476/#comment2972>

    Trailing whitespace here needs removed.



/trunk/KDE/kdelibs/kdeui/colors/kcolorcombo.cpp
<http://reviewboard.kde.org/r/2476/#comment2973>

    Since we're reorganizing the order it would probably be best to move black and white to the top since they should be the most frequently used colors.


- Michael


On 2010-01-09 18:28:50, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2476/
> -----------------------------------------------------------
> 
> (Updated 2010-01-09 18:28:50)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> New (and nicer) KColorCombo palette with more colors.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/colors/kcolorcombo.cpp 1072245 
> 
> Diff: http://reviewboard.kde.org/r/2476/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> old palette
>   http://reviewboard.kde.org/r/2476/s/290/
> new palette
>   http://reviewboard.kde.org/r/2476/s/291/
> 
> 
> Thanks,
> 
> Davide
> 
>