Review Request: KColorCombo styled selection rect

Christoph Feck christoph at maxiom.de
Thu Jan 7 17:18:38 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2475/#review3599
-----------------------------------------------------------



/trunk/KDE/kdelibs/kdeui/colors/kcolorcombo.cpp
<http://reviewboard.kde.org/r/2475/#comment2866>

    Replace the check with an assignment, i.e. simply set "opt.showDecorationSelected = true". If this is not true, the PE_PanelItemViewItem will not paint anything.
    
    Sorry if I was not clear on this.
    


- Christoph


On 2010-01-07 16:25:24, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2475/
> -----------------------------------------------------------
> 
> (Updated 2010-01-07 16:25:24)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch replaces the selection rectangle with a styled selection.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/colors/kcolorcombo.cpp 1071085 
> 
> Diff: http://reviewboard.kde.org/r/2475/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>





More information about the kde-core-devel mailing list