Review Request: KColorCombo styled selection rect
Christoph Feck
christoph at maxiom.de
Sat Jan 2 12:35:57 GMT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2475/#review3557
-----------------------------------------------------------
/trunk/KDE/kdelibs/kdeui/colors/kcolorcombo.cpp
<http://reviewboard.kde.org/r/2475/#comment2824>
* The QStyleOptionViewItem can contain a widget. Use that to get the style when available.
* Use PE_PanelItemViewItem to draw the background. grep for this in kdelibs to get examples.
* Make sure "showDecorationSelected" is true to fix problems with CDE/Motif styles (see bug 164684)
- Christoph
On 2010-01-02 12:08:25, Davide Bettio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2475/
> -----------------------------------------------------------
>
> (Updated 2010-01-02 12:08:25)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> This patch replaces the selection rectangle with a styled selection.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kdeui/colors/kcolorcombo.cpp 1064328
>
> Diff: http://reviewboard.kde.org/r/2475/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Davide
>
>
More information about the kde-core-devel
mailing list