Review Request: SQLite version handling improvements (FindSqlite macro)
Jaroslaw Staniek
staniek at kde.org
Fri Feb 26 22:29:16 GMT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2772/
-----------------------------------------------------------
(Updated 2010-02-26 22:29:16.321001)
Review request for kdelibs and Alexander Neundorf.
Changes
-------
- use Sqlite_FIND_VERSION* of cmake 2.6
- provide variables for reuse
- better docs
Summary
-------
The feature set differs from version to version in case of SQLite. Distributions do not allow to install many versions of SQLite side-by-side, so applications that use SQLite without embedding its source code need to carefully check for features available. Otherwise, for example, the files modified with SQLite can loose silently backward compatibility. To make the version tracking easier, two input variables are used:
* SQLITE_MIN_VERSION - e.g. "3.6.16", if defined, older SQLite versions will not be accepted
* SQLITE_RECOMMENDED_VERSION - "3.6.22", if defined, warning will be displayed for older SQLite versions
This way, checks can be performed earlier - at configure stage.
In addition, version checking is independent of pkg-config tool, so it works on MS Windows in the same way as on Unices.
Diffs (updated)
-----
/trunk/KDE/kdelibs/cmake/modules/FindSqlite.cmake 1096528
Diff: http://reviewboard.kde.org/r/2772/diff
Testing
-------
One of the main users of SQLite, KOffice's Kexi, configures and builds fine. Behaviour of the new script is backward-compatible.
Thanks,
Jaroslaw
More information about the kde-core-devel
mailing list