Review Request: KTextEdit should honor System Settings "Automatic spell checking" setting

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3051/#review4272
-----------------------------------------------------------


When you remove that line, then you are right that it always respects the value from the configuration file. But you also remove the ability for the programmer to change that value by using the "setCheckSpellingEnabled()" function, so I doubt the patch is correct in the current form.

- Christoph


On 2010-02-24 20:37:40, Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3051/
> -----------------------------------------------------------
> 
> (Updated 2010-02-24 20:37:40)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> When the user sets the Automatic Spell Checking enabled or not by default in System Settings, this should be propagated to KTextEdit. If I disabled automatic spell checking then all KTextEdit-based applications should respect this.
> This was intented in http://websvn.kde.org/?view=revision&revision=1002950 but the line I remove prevented it to work properly.
> 
> 
> Diffs
> -----
> 
>   branches/KDE/4.4/kdelibs/kdeui/widgets/ktextedit.cpp 1095665 
> 
> Diff: http://reviewboard.kde.org/r/3051/diff
> 
> 
> Testing
> -------
> 
> I tested with KNotes and the Notes applet and my fix works. 
> 
> 
> Thanks,
> 
> Anne-Marie
> 
>