Review Request: kpasswdserver doesn't need anymore Qt3Support

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3035/#review4247
-----------------------------------------------------------


I'm actually testing a different port right now, but the main point is that I'm writing unittests for kpasswdserver. This will take a bit longer, please hold. I do see a big risk with iterator invalidation in all proposed ports, so I'll only feel safe once I finish writing unittests that test the interesting cases (concurrent pending requests, cancellation, etc.)

- David


On 2010-02-22 14:44:48, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3035/
> -----------------------------------------------------------
> 
> (Updated 2010-02-22 14:44:48)
> 
> 
> Review request for kdelibs, Kevin Ottens and David Faure.
> 
> 
> Summary
> -------
> 
> This patch allows to build kpasswdserver without Qt3Support because all the deprecated code has been removed.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/runtime/kpasswdserver/CMakeLists.txt 1093624 
>   /trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.h 1093624 
>   /trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.cpp 1093624 
> 
> Diff: http://reviewboard.kde.org/r/3035/diff
> 
> 
> Testing
> -------
> 
> I've quickly tested this patch and it seems to work but please double check everything.
> 
> 
> Thanks,
> 
> Davide
> 
>