Review Request: kpasswdserver doesn't need anymore Qt3Support
Dario Freddi
drf54321 at gmail.com
Mon Feb 22 09:29:23 GMT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3035/#review4245
-----------------------------------------------------------
To me there are two main issues, then it's fine
/trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.cpp
<http://reviewboard.kde.org/r/3035/#comment3772>
The list needs sorting here: probably qSort right after the insertion?
/trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.cpp
<http://reviewboard.kde.org/r/3035/#comment3773>
This actually applies also to some other previous pseudo-iterators loop: you actually no longer need the "current" pointer, as you can achieve the very same thing in a cleaner, saner way (and with less lines of code) by using an iterator properly. It is also more maintainable in the long run.
- Dario
On 2010-02-22 09:11:06, Davide Bettio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3035/
> -----------------------------------------------------------
>
> (Updated 2010-02-22 09:11:06)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> This patch allows to build kpasswdserver without Qt3Support because all the deprecated code has been removed.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/runtime/kpasswdserver/CMakeLists.txt 1093624
> /trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.h 1093624
> /trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.cpp 1093624
>
> Diff: http://reviewboard.kde.org/r/3035/diff
>
>
> Testing
> -------
>
> I've quickly tested this patch and it seems to work but please double check everything.
>
>
> Thanks,
>
> Davide
>
>
More information about the kde-core-devel
mailing list