branches/KDE/4.4/kdelibs/kio

[Rolf Eike Beer]

Dawit A wrote:
> On Saturday 20 February 2010 18:44:23 Ingo Klöcker wrote:
> > On Sunday 21 February 2010, Dawit Alemayehu wrote:
> > > SVN commit 1093469 by adawit:
> > > 
> > > - Updated the 'content-disposition' meta data. It has been split into
> > > 
> > >   two and the old one no longer works.
> > >   
> > >   ** Please update this file if and when you change meta data values.
> > > 
> > > **
> > > 
> > > CCMAIL:kde-core-devel at kde.org
> > > 
> > >  M  +2 -2      DESIGN.metadata
> > > 
> > > --- branches/KDE/4.4/kdelibs/kio/DESIGN.metadata #1093468:1093469
> > > @@ -45,8 +45,8 @@
> > > 
> > >  Languages       string          Language(s) send in the
> > > 
> > > "Accept-Language:" HTTP Request Header.
> > > 
> > > -content-
> > > -disposition     string          Suggested name to Save a file as as
> > > returned by a HTTP Header Response. +content-disposition-type
> > > string   Type of content-disposition: "inline" or "attachement.
> > > +content-disposition-filename  string   Filename suggested by the
> > > server under which the HTTP response should be saved as.
> > > 
> > >  request-id	number              Sequence number to identify requests
> > > 
> > > in a MultiGet command.
> > 
> > How does this change relate to our source and binary compatibility
> > guarantees? It will surely break all applications relying on the removed
> > content-disposition meta data.
> 
> I did not make that change. I am simply merely updating the documentation
> because I was bitten by the issue and had to go and read the http ioslave
> documentation to find out why. I believe/assume whomever did it, did it
> before the 4.0 release ????
> 
> Anyhow, I will leave it up to the person that made the modification to
> respond to your question...

Neither did I, but a bit of svn log showed me that those values were already 
used in r709862 which dates back to 2007-09-08. So this should be pre-4.0 
indeed.

I think I should update the document and write down that now you get content-
disposition-foobar if your webserver sends "Content-Disposition: inline; 
foobar=baz" (i.e. you will get _any_ value from Content-Disposition header in 
this map.

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100221/7431ed38/attachment.sig>