Review Request: Check on button state (On/Off) when chosing which icon is to be drawn in a push button.

Hugo Pereira Da Costa hugo at oxygen-icons.org
Sat Feb 20 16:44:23 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3029/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

Check on button state (On/Off) when chosing which icon is to be drawn in a push button.
Note: if accepted, I'd like to backport to 4.4 branch, of course.


This addresses bug 227685.
    https://bugs.kde.org/show_bug.cgi?id=227685


Diffs
-----

  /trunk/KDE//kdelibs/kdeui/kernel/kstyle.cpp 1090815 

Diff: http://reviewboard.kde.org/r/3029/diff


Testing
-------

There is a simple test case provided at https://bugs.kde.org/show_bug.cgi?id=227685
This was tested (successfully) with oxygen (which derives from kstyle)


Thanks,

Hugo





More information about the kde-core-devel mailing list