Review Request: Fix "open with" list contents and ordering

Todd toddrme2178 at
Sat Feb 20 08:58:39 GMT 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-02-20 08:58:38.978564)

Review request for Dolphin and kdelibs.


Here is the new version.  I think I addressed all of David's comments, but this required mostly re-writing things from scratch, so I might have created some new issues.  Let me know if I missed anything or if there is anything else I should change.


In the Dolphin and Konqueror menu you get when right-clicking on a group of files, there is a sub-menu that lists possible applications you can use to open the file.  This list, however, does not reliably show all of the valid applications when multiple mimetypes are selected.  This patch fixes that problem.  Further, it sorts the list based on a weighting determined by how highly ranked the application is in all of the selected mimetypes.  So the higher average priority of an application across all the selected mimetypes, the higher its position in the menu.

Diffs (updated)

  /trunk/KDE/kdelibs/kio/kio/kfileitemactions_p.h 1091061 
  /trunk/KDE/kdelibs/kio/kio/kfileitemactions.cpp 1091061 
  /trunk/KDE/kdelibs/kio/kio/kfileitemactions.h 1091061 



I tested various file types with different combinations of associated applications in different orders.



More information about the kde-core-devel mailing list