Review Request: Use KDialog::Ok button instead of using KDialog::Yes button and then changing the text to the Ok text

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2961/#review4171
-----------------------------------------------------------

Ship it!


Looks good to me, and it doesn't change any functions where the button code used might be returned so there should be no binary compat concern either.

- Michael


On 2010-02-15 22:37:25, Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2961/
> -----------------------------------------------------------
> 
> (Updated 2010-02-15 22:37:25)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Use KDialog::Ok button instead of using KDialog::Yes button and then changing the text to the Ok text
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/dialogs/kmessagebox.cpp 1084781 
> 
> Diff: http://reviewboard.kde.org/r/2961/diff
> 
> 
> Testing
> -------
> 
> Ran kmessageboxtest, everything looked fine
> 
> 
> Thanks,
> 
> Albert
> 
>