Review Request: Check the list to randomize is not empty in KRandomSequence

[Jaime Torres]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2915/#review4149
-----------------------------------------------------------


I think you wanted to check the input parameter, not the local variable. Isn't it?.

- Jaime


On 2010-02-14 15:19:02, Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2915/
> -----------------------------------------------------------
> 
> (Updated 2010-02-14 15:19:02)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Checking the list to randomize is not empty fixes several crashes I get using KRandomSequence in various places.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/util/krandomsequence.h 1090056 
> 
> Diff: http://reviewboard.kde.org/r/2915/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anne-Marie
> 
>