kcm_devinfo moved to kdereview ( Infocenter KCM )

[David Hubner]

On 09/02/2010 21:33, Albert Astals Cid wrote:
> A Diumenge, 7 de febrer de 2010, David Hubner va escriure:
>> On Sunday 07 February 2010 15:33:01 Albert Astals Cid wrote:
>>> A Dissabte, 6 de febrer de 2010, David Hubner va escriure:
>>>> On Thursday 28 January 2010 19:59:44 David Hubner wrote:
>>>>> Hi,
>>>>>
>>>>> I have moved the kcm devinfo from playground to kdereview. Its a
>>>>> solid based device information viewer that hopefully will replace the
>>>>> devices kcm in Infocenter.
>>>>>
>>>>> Features:
>>>>> - Tree like view of all devices.
>>>>> - Information on all devices detectable by solid
>>>>> - Display IP(V4) information and status on NIC's
>>>>> - Automatic insertion and deletion of devices in the tree
>>>>>
>>>>> At the moment it can replace the Network Interfaces, Devices, Sound,
>>>>> Processor Information and Usb devices KCM in Infocenter. Hopefully it
>>>>> can replace the partitions KCM soon as well. ( see TODO )
>>>>>
>>>>> Todo:
>>>>> - Submitted two patches to Solid, if they are added i should be able
>>>>> to add volume and storage device, available and used space meters.
>>>>>
>>>>> Main KDE Libs Needed:
>>>>> Solid
>>>>> Solid::Control (KdeBase)
>>>>> KIO
>>>>>
>>>>> I am hoping with some input it can be moved into KDE.
>>>>>
>>>>> Thanks
>>>>
>>>> As requested
>>>>
>>>> 1. Added tooltips on devices ( at the moment shows "A Device", it will
>>>> show device.description() when 4.4 comes out. 2. Fixed the empty
>>>> message issue. 3. Added Docbook to the SVN.
>>>> 4. Added Whats This parts to the application.
>>>> 4. Fixed spelling issues.
>>>> 5. All the right side is selectable so you can copy.
>>>> 6. QList<QString>  changed to QStringList.
>>>>
>>>> Also added size detection on volumes so they have usage/availability
>>>> and size.
>>>>
>>>> Could people review this again, to see if there is any remaining
>>>> issues. Its in Kdereview under kcm_devinfo.
>>>
>>> You are missing some const and const&  here and there, examples
>>>
>>>      template<class IFace>  const IFace *getInterface(Solid::Device
>>> device) can probably be
>>>      template<class IFace>  const IFace *getInterface(const Solid::Device
>>> &device)
>>>
>>>      QString getUdi();
>>> can probably be
>>>      QString getUdi() const;
>>>
>>>      void setDeviceIcon(KIcon);
>>>      void setDeviceToolTip(const QString);
>>> can probably be
>>>      void setDeviceIcon(const KIcon&);
>>>      void setDeviceToolTip(const QString&);
>>>
>>>      QIcon getDeviceIcon();
>>> can probably be
>>>      QIcon getDeviceIcon() const;
>>>
>>> And some more, drop by #kde-devel if you feel unsure where const and
>>> const&  should be applied.
>>>
>>> That beside that the KDE/Qt convention is not to put getFoo() but just
>>> foo() but that's just the general convention, don't think it's necessary
>>> to change it if you don't feel like.
>>>
>>> Albert
>>>
>>>> Thanks
>>
>> All changed :) Sorry about that, not using constants is a bad programming
>>   practise of mine.
>>
>> Any other changes that need to be made?
>
> Not from my side.
>
> Albert
>
>>
>> Thanks
>>
>

Anyone know the next stage to get this upstream? Also is there a 
maintainer for KInfoCenter because I was thinking of redoing the samba 
and X sections of it as well.

Thanks