Review Request: Add "Sort Folders First" option in the file dialog
Frank Reininghaus
frank78ac at googlemail.com
Tue Feb 9 14:28:37 GMT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2863/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
It was recently noted on kde-core-devel that the file dialog's sorting options lack the "Folders First" setting that Dolphin has since 4.3 [1].
This patch implements that, such that the "Sort" menus in Dolphin/DolphinPart and the file dialog are the same again.
I know that the change is rather small, but I thought I'd better get some review before committing because it's a new feature and because I used a rather hackish approach in KDirOperator::Private::updateSorting(QDir::SortFlags sort)
to re-sort the files&folders if the new setting is toggled. If anyone has a better idea how to achieve this, please let me know.
[1] http://lists.kde.org/?l=kde-core-devel&m=126517610620319&w=2
Diffs
-----
/trunk/KDE/kdelibs/kfile/kdiroperator.cpp 1087568
Diff: http://reviewboard.kde.org/r/2863/diff
Testing
-------
Works as expected for me.
Thanks,
Frank
More information about the kde-core-devel
mailing list