Review Request: Add "Sort Folders First" option in the file dialog

Frank Reininghaus frank78ac at
Tue Feb 9 14:28:37 GMT 2010

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.


It was recently noted on kde-core-devel that the file dialog's sorting options lack the "Folders First" setting that Dolphin has since 4.3 [1].

This patch implements that, such that the "Sort" menus in Dolphin/DolphinPart and the file dialog are the same again.

I know that the change is rather small, but I thought I'd better get some review before committing because it's a new feature and because I used a rather hackish approach in KDirOperator::Private::updateSorting(QDir::SortFlags sort)
to re-sort the files&folders if the new setting is toggled. If anyone has a better idea how to achieve this, please let me know.



  /trunk/KDE/kdelibs/kfile/kdiroperator.cpp 1087568 



Works as expected for me.



More information about the kde-core-devel mailing list