Review Request: Add an associated widget to the action collection in KDirSelectDialog

[Raphael Kubo da Costa]

> On 2010-02-07 21:54:58, Aaron Seigo wrote:
> > i assume the same needs to be done for the regular file dialog, as the shortcuts don't work there either.

What file dialog are you referring to? When I open the default save dialog, for example, shortcuts work fine (Alt+Enter for Properties, F5 for Reload etc).


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2838/#review4092
-----------------------------------------------------------


On 2010-02-07 04:21:54, Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2838/
> -----------------------------------------------------------
> 
> (Updated 2010-02-07 04:21:54)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> None of the shortcuts defined in KDirSelectDialog (such as Show hidden files, Create New Folder etc) were working, although triggering the actions in another way did work as expected.
> 
> The shortcuts work fine if the dialog itself is added as an associated widget of the action collection.
> 
> I don't know how long it's been broken (or if it has ever worked as expected ;). Is a unit test required?
> 
> 
> This addresses bug 225744.
>     https://bugs.kde.org/show_bug.cgi?id=225744
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/kdirselectdialog.cpp 1083310 
> 
> Diff: http://reviewboard.kde.org/r/2838/diff
> 
> 
> Testing
> -------
> 
> Bug 225744 couldn't be reproduced after the patch.
> 
> 
> Thanks,
> 
> Raphael
> 
>