Review Request: change KShortcutsDialog header

David Faure faure at kde.org
Sat Feb 6 00:53:05 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2802/#review4085
-----------------------------------------------------------

Ship it!


Sure.

- David


On 2010-02-03 13:38:24, Aleks wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2802/
> -----------------------------------------------------------
> 
> (Updated 2010-02-03 13:38:24)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> As per https://bugs.kde.org/show_bug.cgi?id=218485#c8
> QAction should not be used in KShortcutsDialog.
> This adds the caveat to documentation.
> Also some other funcs might need to be amended.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/dialogs/kshortcutsdialog.h 1084675 
> 
> Diff: http://reviewboard.kde.org/r/2802/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleks
> 
>





More information about the kde-core-devel mailing list