[KDE Usability] Review Request: Add "Open File Manager" action to KFileDialog toolbar

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2757/#review4029
-----------------------------------------------------------

Ship it!


Looks good. A menu item is exactly what I had in mind. I can't remember where, but I'm sure I have seen this in at least one other file dialog before.


/trunk/KDE/kdelibs/kfile/kdiroperator.cpp
<http://reviewboard.kde.org/r/2757/#comment3410>

    "parent" would be a better argument than QApplication::activeWindow()
    [which could be NULL meanwhile, on a very busy system if the user manages to switch windows, I think]


- David


On 2010-01-30 23:33:53, Harsh J wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2757/
> -----------------------------------------------------------
> 
> (Updated 2010-01-30 23:33:53)
> 
> 
> Review request for kdelibs, usability, Shaun Reich, and David Faure.
> 
> 
> Summary
> -------
> 
> Patch proposes to add a "Open File Manager" button (with system-file-manager icon) to the KFileDialog toolbar, alongside the inline preview button.
> 
> This will open the current Url the dialog is in, in the default file manager (via KRun).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/kdiroperator.h 1082235 
>   /trunk/KDE/kdelibs/kfile/kdiroperator.cpp 1082235 
> 
> Diff: http://reviewboard.kde.org/r/2757/diff
> 
> 
> Testing
> -------
> 
> Works with any directory the dialog is currently viewing.
> 
> 
> Screenshots
> -----------
> 
> Open File Manager in Open File dialog toolbar
>   http://reviewboard.kde.org/r/2757/s/307/
> 
> 
> Thanks,
> 
> Harsh
> 
>