Review Request: Merge changes from ffmpethumbnail projekt into the kde version
Christoph Feck
christoph at maxiom.de
Thu Dec 9 23:41:38 GMT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5937/#review9191
-----------------------------------------------------------
Ship it!
The changes are fine, I just don't like the filmstrip.h file. The upstream project has to use it, because it doesn't have a way to paint on a QImage. But if you want to work on it later, please commit this for now, too small holes don't look nice on HD video files :)
- Christoph
On 2010-11-22 20:16:46, Andreas Scherf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5937/
> -----------------------------------------------------------
>
> (Updated 2010-11-22 20:16:46)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> + Some type changes (uinXX to quintXX), some code cleanup and some compile fixes.
>
>
> Diffs
> -----
>
> trunk/KDE/kdemultimedia/CMakeLists.txt 1199813
> trunk/KDE/kdemultimedia/cmake/modules/FindFFMPEG.cmake PRE-CREATION
> trunk/KDE/kdemultimedia/ffmpegthumbs/CMakeLists.txt 1199813
> trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/ChangeLog 1199813
> trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/filmstrip.h PRE-CREATION
> trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/filmstripfilter.cpp 1199813
> trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/moviedecoder.h 1199813
> trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/moviedecoder.cpp 1199813
> trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videoframe.h 1199813
> trunk/KDE/kdemultimedia/ffmpegthumbs/ffmpegthumbnailer/videothumbnailer.h 1199813
>
> Diff: http://svn.reviewboard.kde.org/r/5937/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andreas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101209/1bb73aa5/attachment.htm>
More information about the kde-core-devel
mailing list