Review Request: Adds method to KBookmarkManager disable showing dialogs on errors.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6004/#review9157
-----------------------------------------------------------



/trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h
<http://svn.reviewboard.kde.org/r/6004/#comment9992>

    I would prefer if it was named like the similar method in KDirLister:
    
      /**
       * Check whether auto error handling is enabled.
       * If enabled, it will show an error dialog to the user when an
       * error occurs. It is turned on by default.
       * @return true if auto error handling is enabled, false otherwise
       * @see setAutoErrorHandlingEnabled()
       */
      bool autoErrorHandlingEnabled() const;
    
      /**
       * Enable or disable auto error handling is enabled.
       * If enabled, it will show an error dialog to the user when an
       * error occurs. It is turned on by default.
       * If disabled, the application should react on the error() signal.
       * @param enable true to enable auto error handling, false to disable
       * @param parent the parent widget for the error dialogs, can be 0 for
       *               top-level
       * @see autoErrorHandlingEnabled()
       */
      void setAutoErrorHandlingEnabled( bool enable, QWidget *parent );
    
    (the QWidget* would also allow to give a proper parent widget for the dialog box instead of the current activeWindow() hack)
    



/trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h
<http://svn.reviewboard.kde.org/r/6004/#comment9991>

    const QString &


- David


On 2010-11-30 20:57:03, Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6004/
> -----------------------------------------------------------
> 
> (Updated 2010-11-30 20:57:03)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> Adds method to KBookmarkManager disable showing dialogs on errors.
> This way it is possible to deactivate those messages if KBoomarkManager is not run in the gui thread.
> BUG:207592
> 
> 
> This addresses bug 207592.
>     https://bugs.kde.org/show_bug.cgi?id=207592
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h 1202414 
>   /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.cc 1202414 
> 
> Diff: http://svn.reviewboard.kde.org/r/6004/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matthias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101206/dec00968/attachment.htm>