ksnapshot assert fail

David Faure faure at kde.org
Fri Dec 3 19:52:10 GMT 2010

[ksnapshot was indeed fixed rather long ago for this, but let's discuss the 
kdialog behavior]

On Thursday 02 December 2010, Aaron J. Seigo wrote:
> it's KDialog that making the assertion; and the assertion looks bogus since
> it's absolutely plausible that the app requests the default to be a button
> that doesn't actually exist.

The point is that making a non-existing button default never worked. But 
before it would just silently break, while now it asserts.

(and the assert says "defaultButton will return the value set by 
setDefaultButton", it can't possibly be a wrong assert, it just revealed the 
issue of calling the method with a non-existing button).

I guess your point is "KDialog should remember and make the button default 
once it exists". Hmm. It can be done indeed. I don't know if it's worth the 
additional complexity, but if you feel this should work, please review the 
attached patch. Unittest passes, of course.

David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dialogs.diff
Type: text/x-patch
Size: 2997 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101203/25e0f5dc/attachment.bin>

More information about the kde-core-devel mailing list