Potential issue in kshareddatacache.cpp checkin revision 1193778

Vishal Rao vishalrao at gmail.com
Fri Dec 3 05:07:06 GMT 2010


Hello,

Sorry if this is spam/silly.

I happened to notice this while browsing the 4.5.4 release announcement pages:

unsigned KSharedDataCache::totalSize() const

has added:

if (lock.failed()) {
  return false;
}

Returning bool false for return type unsigned - is this a potential
problem or do you check for MAX_UINT or whatever?

Regards,
Vishal

-- 
"Thou shalt not follow the null pointer for at its end madness and chaos lie."




More information about the kde-core-devel mailing list