Review Request: Move from KTabWidget to KTabBar tab switching by mouse wheel events.

[David Palacio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5184/
-----------------------------------------------------------

(Updated 2010-08-31 15:54:54.748971)


Review request for kdelibs.


Changes
-------

* emit 'wheelDelta' again.
* Reuse Qt's implementation to avoid disabled tabs
* Disable duplicated code from Konsole and Dolphin


Summary
-------

KTabWidget implements tab switching as response to mouse wheel events. This makes applications like Rekonq, that use a KTabBar instead, do nothing when the wheel is scrolled.

The proposed patch moves the behaviour implementation from KTabWidget to
KTabBar, disables and disconnects the relevant signal in KTabBar/KTabWidget.

Note that QTabBar in Qt already implements this with a small difference: it
does not wrap around the extreme tabs. That is, it will not go from the last to
the first tab and viceversa.


This addresses bug 248962.
    https://bugs.kde.org/show_bug.cgi?id=248962


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/dolphin/src/dolphinmainwindow.h 1170268 
  /trunk/KDE/kdebase/apps/dolphin/src/dolphinmainwindow.cpp 1170268 
  /trunk/KDE/kdebase/apps/konsole/src/ViewContainer.cpp 1170268 
  /trunk/KDE/kdelibs/kdeui/widgets/ktabbar.cpp 1170208 
  /trunk/KDE/kdelibs/kdeui/widgets/ktabwidget.cpp 1170208 

Diff: http://reviewboard.kde.org/r/5184/diff


Testing
-------

Rekonq works as expected.
KTabWidget users, such as Konqueror and Konsole work as well.


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100831/2c75ea44/attachment.htm>