Review Request: ftp server URL throws "invalid protocol" - Bug: 209031

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5148/#review7239
-----------------------------------------------------------

Ship it!


except for the nitpik below, it looks good to me...


/tags/KDE/4.5.0/kdelibs/kfile/kurlnavigator.cpp
<http://reviewboard.kde.org/r/5148/#comment7346>

    nitpick... there is really no reason to do "url.url()" here, passing url works since that function is overloaded...


- Dawit


On 2010-08-26 22:58:00, Mark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5148/
> -----------------------------------------------------------
> 
> (Updated 2010-08-26 22:58:00)
> 
> 
> Review request for Dolphin, kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> Read the bug report for the.. bug..
> 
> As for the fix. I had a hard time finding the right place to implement this since all was using const KUrl thus not editable... When searching deeper i ended up in making the fix in either KUrlNavigator or in KUrl itself. I decided to go for KUrlNavigator for no particular reason... I could just as well have tried it in KUrl. I hope this KUrlNavigator was the right place (either way, please do explain where is the right place and why the other one isn't the right place). 
> 
> 
> This addresses bug 209031.
>     https://bugs.kde.org/show_bug.cgi?id=209031
> 
> 
> Diffs
> -----
> 
>   /tags/KDE/4.5.0/kdelibs/kfile/kurlnavigator.cpp 1168303 
> 
> Diff: http://reviewboard.kde.org/r/5148/diff
> 
> 
> Testing
> -------
> 
> I did one simple tests on it:
> typing "ftp.nluug.nl" in the url bar and pressing enter. It changed the url to "ftp://ftp.nluug.nl" and the ftp opened just perfectly. I browsed a bit on it to see if it stays working fins and it seems to do just that.
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100827/d062b49b/attachment.htm>