KDE_VERSION_STRING

[George Kiagiadakis]

On Thu, Aug 26, 2010 at 11:34 PM, Aaron J. Seigo <aseigo at kde.org> wrote:
> hi...
>
> so, KDE_VERSION_STRING (or KDE::versionString()) was saying that it was "KDE
> x.y.z" which is no longer accurate. it's the platform.
>
> so i changed that in kdelibs/CMakeLists.txt ... but as was pointed out on irc,
> all of the places it appears already say "KDE Platform", so it starts to get
> really redundant.
>
> i'd like to propose that we remove the term "KDE" from the version string
> altogether and leave it completely up to the GUIs, so the patch becomes:
>
>  set (KDE_VERSION_MAJOR 4)
>  set (KDE_VERSION_MINOR 5)
>  set (KDE_VERSION_RELEASE 66)
>  set (KDE_VERSION "${KDE_VERSION_MAJOR}.${KDE_VERSION_MINOR}.
> ${KDE_VERSION_RELEASE}" )
> -set (KDE_VERSION_STRING "${KDE_VERSION} (KDE Platform 4.5.66 (KDE Platform
> 4.6 >= 20100825))")
> +set (KDE_VERSION_STRING "${KDE_VERSION} (4.6 >= 20100825)")
>
> this matches the apidox for KDE::versionString as well, and the repititoin of
> "4.5.66" which we get from KDE_VERSION.
>
> comments?

+1. It makes no sense to repeat the same thing over and over in the same place.

Btw, the stuff in parenthesis (4.6 >= 20100825) is ok for snapshots,
but I don't think it makes sense for releases. Currently, for
releases, it is set to say the same thing as KDE_VERSION. For example
on 4.5.0 I have:

#define KDE_VERSION_STRING "4.5.00 (KDE 4.5.0)"

Now if we drop the "KDE", it will say "4.5.00 (4.5.0)". Imho it should
be dropped completely from releases and let KDE_VERSION_STRING be the
same as KDE_VERSION.