Review Request: ftp server URL throws "invalid protocol" - Bug: 209031

[Rolf Eike Beer]

You wrote:
> > On 2010-08-26 16:34:56, Rolf Eike Beer wrote:
> > > Why is that startsWith("ftp.") and not just startsWith("ftp")? I'm
> > > always annoyed Konqueror gets ftp5.gwdg.de wrong ;)
> 
> simple. If i do startsWith("ftp") then anything that starts with "ftp" will
> get the ftp:// prefix.. Besides, ftp. and ftp://ftp. is common. ftp5. is
> far from common if you ask me ^_^ And changing this would mean that
> anything before the point that contans "ftp" should get ftp:// ... i'm not
> sure if that's a good idea although not hard to make.

Well, it's a heuristic. They have to be sometimes wrong ;)

> everything before the first point then .contains("ftp") and voila.. ^_^

I would stay at startsWith() instead of contains().

> But, someone else.. Is this a required change?

No.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100826/2c4177b1/attachment.sig>