KDE_VERSION_STRING

Aaron J. Seigo aseigo at kde.org
Thu Aug 26 21:34:22 BST 2010


hi...

so, KDE_VERSION_STRING (or KDE::versionString()) was saying that it was "KDE 
x.y.z" which is no longer accurate. it's the platform.

so i changed that in kdelibs/CMakeLists.txt ... but as was pointed out on irc, 
all of the places it appears already say "KDE Platform", so it starts to get 
really redundant.

i'd like to propose that we remove the term "KDE" from the version string 
altogether and leave it completely up to the GUIs, so the patch becomes:

 set (KDE_VERSION_MAJOR 4)
 set (KDE_VERSION_MINOR 5)
 set (KDE_VERSION_RELEASE 66)
 set (KDE_VERSION "${KDE_VERSION_MAJOR}.${KDE_VERSION_MINOR}.
${KDE_VERSION_RELEASE}" )
-set (KDE_VERSION_STRING "${KDE_VERSION} (KDE Platform 4.5.66 (KDE Platform 
4.6 >= 20100825))")
+set (KDE_VERSION_STRING "${KDE_VERSION} (4.6 >= 20100825)")

this matches the apidox for KDE::versionString as well, and the repititoin of 
"4.5.66" which we get from KDE_VERSION.

comments?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100826/21b82ea3/attachment.sig>


More information about the kde-core-devel mailing list