Review Request: Use Qt cout and cerr

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5158/#review7227
-----------------------------------------------------------


Some comments from my side:


/trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp
<http://reviewboard.kde.org/r/5158/#comment7342>

    Make global variables "static", otherwise they might appear in the symbol table.



/trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp
<http://reviewboard.kde.org/r/5158/#comment7343>

    You do not need qPrintable, because QTextStream knows how to print a QString (the same reason you could remove the QString overload of operator<<)


- Christoph


On 2010-08-26 15:39:13, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5158/
> -----------------------------------------------------------
> 
> (Updated 2010-08-26 15:39:13)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Use Qt cout and cerr. Qt already has in cout the methods for a lot of Qt data types.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp 1168408 
> 
> Diff: http://reviewboard.kde.org/r/5158/diff
> 
> 
> Testing
> -------
> 
> Works in linux and cygwin.
> 
> 
> Thanks,
> 
> Jaime
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100826/5491d02f/attachment.htm>