Review Request: Add 'restore' method to Sonnet::BackgroundChecker.

[Michel Ludwig]

> On 2010-08-17 20:48:06, David Faure wrote:
> > Ah. I don't know the code, but this sounds good. Feel free to commit if nobody else comments on this patch (not many people working on sonnet afaik).
> > 
> > Would this mechanism also allow to fix bug 244911, where options need to be passed to the filters?

No, I think bug 244911 relates to another problem, i.e. there currently doesn't seem to exist a way to programmatically tell the spell checking plugins that run-together words should be skipped. 


- Michel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4901/#review7120
-----------------------------------------------------------


On 2010-08-04 13:05:13, Michel Ludwig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4901/
> -----------------------------------------------------------
> 
> (Updated 2010-08-04 13:05:13)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Recently, the handling of spell checking for upper-case words was fixed in Sonnet::Filter. While this might now work correctly with KTextEdit widgets through Sonnet::Highlighter, although potentially configured differently upper-case words might still be spell checked with Sonnet::BackgroundChecker. This is due to the fact that Sonnet::BackgroundChecker does not possess a way to load or reload specific spell checking configurations.
> 
> This patch fixes the problem by adding a 'restore' method to Sonnet::BackgroundChecker, which allows it to read a spell checking configuration and then to pass it on to the filter object that is used internally. The implementation is similar to what is done inside Sonnet::Highlighter.
> 
> This patch should also be back-ported to 4.5 eventually.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdecore/sonnet/backgroundchecker.h 1159072 
>   trunk/KDE/kdelibs/kdecore/sonnet/backgroundchecker.cpp 1159072 
> 
> Diff: http://reviewboard.kde.org/r/4901/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100818/f5937f1f/attachment.htm>