Review Request: Adding "net usershare" suport for KSambaShare

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4320/#review6910
-----------------------------------------------------------


Thanks for your work and sorry again for taking so long to come back to you.

I am a bit worried by the fact that the KSambaShare::add() method was commented out: how did you manage to test the code without this method? I think this is probably the last missing part: getting this code hooked in the file property dialog or providing a unittest to ensure the API works well. You can have a look at kdelibs/kio/tests to see how to implement tests for your work. I think writing a test program to add/remove shares should be simple and a good way to prove your API is sufficient.


/trunk/KDE/kdelibs/kio/kio/ksambashare.h
<http://reviewboard.kde.org/r/4320/#comment6884>

    I guess this line should not be commented out. I also guess it should be KSambaShareData, not KSambaShareInfo.
    
    The implementation of the function is missing.



/trunk/KDE/kdelibs/kio/kio/ksambashare.cpp
<http://reviewboard.kde.org/r/4320/#comment6886>

    Is there a reason for KSambaSharePrivate to be a singleton? I am afraid that could lead to subtle bugs because the singleton is deleted in KSambaShare destructor, but KSambaSharePrivate::_instance is not reset to 0.
    
    You can of course take care of resetting KSambaSharePrivate::_instance properly, but it feels simpler to just not make it a singleton.



/trunk/KDE/kdelibs/kio/kio/ksambashare.cpp
<http://reviewboard.kde.org/r/4320/#comment6885>

    Nitpick: Better use kWarning() here, and output the content of stdErr



/trunk/KDE/kdelibs/kio/kio/ksambasharedata.h
<http://reviewboard.kde.org/r/4320/#comment6887>

    Nitpick: It would be more familiar to name this typedef KSambaShareDataPrivatePtr.


- Aurélien


On 2010-07-28 00:57:16, Rodrigo Belem wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4320/
> -----------------------------------------------------------
> 
> (Updated 2010-07-28 00:57:16)
> 
> 
> Review request for kdelibs, Jonathan Thomas, Aurélien Gâteau, Jonathan Riddell, Adenilson Cavalcanti, and loureiro.
> 
> 
> Summary
> -------
> 
> KDE needs to support modern samba tools. With the "net usershare" command line tool the users can manage their shares. The attached patch intends to add support for this tool.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/CMakeLists.txt 1152786 
>   /trunk/KDE/kdelibs/kio/kio/ksambashare.h 1152786 
>   /trunk/KDE/kdelibs/kio/kio/ksambashare.cpp 1152786 
>   /trunk/KDE/kdelibs/kio/kio/ksambashare_p.h PRE-CREATION 
>   /trunk/KDE/kdelibs/kio/kio/ksambasharedata.h PRE-CREATION 
>   /trunk/KDE/kdelibs/kio/kio/ksambasharedata.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/kio/kio/ksambasharedata_p.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4320/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rodrigo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100809/3e0d0c8b/attachment.htm>