Review Request: KFileMetaDataWidget: Provide signal when the request for meta data has been finished

[Peter Penz]

> On 2010-08-09 10:02:52, David Faure wrote:
> > A new signal is no problem in 4.5.1 indeed. However I wonder if this is good API? I mean: what happens if you call setItems() multiple times? When you get the signal, you don't know which items it relates to.

You're right, I'd suggest that the signal is extended by a 'KFileItemList' parameter for this. Or do you have general concerns about this signal?


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4777/#review6896
-----------------------------------------------------------


On 2010-07-29 15:27:58, Peter Penz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4777/
> -----------------------------------------------------------
> 
> (Updated 2010-07-29 15:27:58)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> To be able to fix bug https://bugs.kde.org/show_bug.cgi?id=245491 in a clean way for KDE SC 4.5.1, I'd need to introduce a new signal to the class KFileMetaDataWidget (see [1]).
> 
> - Is it allowed to introduce a new signal to a bugfix release, if this is required to fix a bug?
> - Should I add a @since KDE SC 4.5.1 tag to the documentation? (a related fix in Dolphin that uses this signal would be committed later in this case)
> 
> 
> [1] KFileMetaDataWidget requests the meta data for KFileItems asynchronously. Usually applications don't need to care about this, but in the case if this widget is shown inside a tooltip, it is an important detail. This is because the tooltip should not be resized after it has been opened already. Resizing a tooltip if it is already open gets especially a problem on the right/bottom corners (-> clipping, repositioning, take care not to overlap the mouse pointer...) With this signal it is possible to postpone the opening of the tooltip, until the information has been received.
> 
> 
> This addresses bug 245491.
>     https://bugs.kde.org/show_bug.cgi?id=245491
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.5/kdelibs/kio/kfile/kfilemetadatawidget.h 1156711 
>   /branches/KDE/4.5/kdelibs/kio/kfile/kfilemetadatawidget.cpp 1156711 
> 
> Diff: http://reviewboard.kde.org/r/4777/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Peter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100809/e56ceacf/attachment.htm>