Review Request: Fix KArchiveFile::copyTo() for large files

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4938/#review6877
-----------------------------------------------------------


typically I like to see reading and writing methods return a boolean for success or failure.  but I have no idea if that makes sense here.

else, the code looks fine to me.


/trunk/KDE/kdelibs/kdecore/io/karchive.cpp
<http://reviewboard.kde.org/r/4938/#comment6781>

    does it make better sense to return false and change copyTo() a boolean method?
    


- Allen


On 2010-08-08 20:00:59, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4938/
> -----------------------------------------------------------
> 
> (Updated 2010-08-08 20:00:59)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This fixes KArchiveFile::copyTo() to read in chunks (same as KArchive::addLocalFile(), i.e. 8192 byte chunks) instead of loading the whole file into a single QByteArray (and overflow large files due to that).
> 
> 
> This addresses bug 237124.
>     https://bugs.kde.org/show_bug.cgi?id=237124
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/io/karchive.cpp 1160676 
> 
> Diff: http://reviewboard.kde.org/r/4938/diff
> 
> 
> Testing
> -------
> 
> I successfully downloaded and installed the UNSO NOMAD catalog mentioned in the bug report using the KStars GHNS dialog. During download and copying/extracting the RES memory size of process kstars did not exceed 60 MB. The download file size was 1450631611 (1.35 GiB), the extracted destination file size was 2173117930 (2.02 GiB).
> 
> 
> Thanks,
> 
> Christoph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100808/2d5299ac/attachment.htm>