Review Request: Make DBusMenuQt optional

[Ingo Klöcker]

> On 2010-08-06 07:10:08, Aaron Seigo wrote:
> > personally, i'm fine with the patch, if only for correctness in terms of "as few hard requirements as possible."
> > 
> > in practice, i find the usefulness of the patch to be dubious, but it can't hurt to at least allow it to be optional :)

KDAB could have chosen to take the route that the KOffice guys took, i.e. create (fork) their own private version of kdelibs by throwing out everything that they do not need. They did not choose this route. Instead they chose to work directly with upstream. This requires upstream not to block patches for dubious reasons. We don't do so in this case (which is good), but we still try to argue why the patch makes no sense. It makes no sense to us (which is perfectly okay), but apparently it does make sense for KDAB because otherwise they wouldn't have asked.


- Ingo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4898/#review6833
-----------------------------------------------------------


On 2010-08-06 12:34:16, Marc Mutz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4898/
> -----------------------------------------------------------
> 
> (Updated 2010-08-06 12:34:16)
> 
> 
> Review request for kdelibs, Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> Make DBusMenuQt optional.
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.5/kdebase/workspace/CMakeLists.txt 1159836 
>   /branches/KDE/4.5/kdebase/workspace/ConfigureChecks.cmake 1159836 
>   /branches/KDE/4.5/kdebase/workspace/config-workspace.h.cmake 1159836 
>   /branches/KDE/4.5/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt 1159836 
>   /branches/KDE/4.5/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.cpp 1159836 
>   /branches/KDE/4.5/kdelibs/CMakeLists.txt 1159039 
>   /branches/KDE/4.5/kdelibs/ConfigureChecks.cmake 1159039 
>   /branches/KDE/4.5/kdelibs/config.h.cmake 1159039 
>   /branches/KDE/4.5/kdelibs/kdeui/CMakeLists.txt 1159039 
>   /branches/KDE/4.5/kdelibs/kdeui/notifications/kstatusnotifieritem.cpp 1159039 
> 
> Diff: http://reviewboard.kde.org/r/4898/diff
> 
> 
> Testing
> -------
> 
> Compiles w/o DBusMenuQt present.
> 
> 
> Thanks,
> 
> Marc
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100806/4a444739/attachment.htm>