Review Request: Make DBusMenuQt optional

Marc Mutz marc at kdab.com
Fri Aug 6 13:33:21 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4898/
-----------------------------------------------------------

(Updated 2010-08-06 12:33:20.530711)


Review request for kdelibs and Marco Martin.


Changes
-------

Changes compared to the first version:
kdelibs:
- use URL from FindDBusMenuQt.cmake in macro_log_feature()
kdebase:
- make DBusMenuQt optional in plasma


Summary
-------

Make DBusMenuQt optional.


Diffs (updated)
-----

  /branches/KDE/4.5/kdebase/workspace/CMakeLists.txt 1159836 
  /branches/KDE/4.5/kdebase/workspace/ConfigureChecks.cmake 1159836 
  /branches/KDE/4.5/kdebase/workspace/config-workspace.h.cmake 1159836 
  /branches/KDE/4.5/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt 1159836 
  /branches/KDE/4.5/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.cpp 1159836 
  /branches/KDE/4.5/kdelibs/CMakeLists.txt 1159039 
  /branches/KDE/4.5/kdelibs/ConfigureChecks.cmake 1159039 
  /branches/KDE/4.5/kdelibs/config.h.cmake 1159039 
  /branches/KDE/4.5/kdelibs/kdeui/CMakeLists.txt 1159039 
  /branches/KDE/4.5/kdelibs/kdeui/notifications/kstatusnotifieritem.cpp 1159039 

Diff: http://reviewboard.kde.org/r/4898/diff


Testing
-------

Compiles w/o DBusMenuQt present.


Thanks,

Marc

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100806/41deb32b/attachment.htm>


More information about the kde-core-devel mailing list