Review Request: Make DBusMenuQt optional

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4898/#review6836
-----------------------------------------------------------


did you try if besides compiling the menus still show up correctly?
as already said, to me the patch is fine even if i don't see a need to -not- have dbusmenu
on mobile if possible is even more needed, since yes, you still have to show list of actions, but of course don't want QMenus and dbusmenu makes this quite easy.
that said yes, i understand there could be scenarioswhere you can't afford a dependency more

- Marco


On 2010-08-06 12:34:16, Marc Mutz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4898/
> -----------------------------------------------------------
> 
> (Updated 2010-08-06 12:34:16)
> 
> 
> Review request for kdelibs, Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> Make DBusMenuQt optional.
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.5/kdebase/workspace/CMakeLists.txt 1159836 
>   /branches/KDE/4.5/kdebase/workspace/ConfigureChecks.cmake 1159836 
>   /branches/KDE/4.5/kdebase/workspace/config-workspace.h.cmake 1159836 
>   /branches/KDE/4.5/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt 1159836 
>   /branches/KDE/4.5/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.cpp 1159836 
>   /branches/KDE/4.5/kdelibs/CMakeLists.txt 1159039 
>   /branches/KDE/4.5/kdelibs/ConfigureChecks.cmake 1159039 
>   /branches/KDE/4.5/kdelibs/config.h.cmake 1159039 
>   /branches/KDE/4.5/kdelibs/kdeui/CMakeLists.txt 1159039 
>   /branches/KDE/4.5/kdelibs/kdeui/notifications/kstatusnotifieritem.cpp 1159039 
> 
> Diff: http://reviewboard.kde.org/r/4898/diff
> 
> 
> Testing
> -------
> 
> Compiles w/o DBusMenuQt present.
> 
> 
> Thanks,
> 
> Marc
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100806/3f567fa2/attachment.htm>
-------------- next part --------------
_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel