Review Request: Add thumbnail support for .lnk files

[Nicholas van Oudtshoorn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4817/
-----------------------------------------------------------

(Updated 2010-08-05 09:14:45.841469)


Review request for kdelibs.


Changes
-------

As per suggestions, now using IcoUtils to convert from Ico to Png
(At some stage, I'll have to see about getting rid of the wrestool dependency.... :) )

Also, there's a rudimentary fall back to using the actual windows path embedded in the LNK file, which should make this plugin somewhat useful on windows.


Summary
-------

This patch implements thumbnailing support for Microsoft Windows link files (.lnk) via the thumbnail kioslave

It uses the external application "winepath" - part of the wine package (www.winehq.org) to translate windows paths to their unix equivalents. If said path (or indeed the winepath application) doesn't exist, no thumbnail is drawn.


Diffs (updated)
-----

  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowslnkthumbnail.desktop PRE-CREATION 
  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/icoutils.h 1158174 
  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/icoutils.cpp 1158174 
  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowslnkcreator.h PRE-CREATION 
  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowslnkcreator.cpp PRE-CREATION 
  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/CMakeLists.txt 1158174 

Diff: http://reviewboard.kde.org/r/4817/diff


Testing
-------

Works for me!


Thanks,

Nicholas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100805/d90b012f/attachment.htm>